Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: Tuya valve random model id #931

Merged
merged 1 commit into from
Jun 22, 2021
Merged

ADD: Tuya valve random model id #931

merged 1 commit into from
Jun 22, 2021

Conversation

koying
Copy link
Contributor

@koying koying commented Jun 21, 2021

@MattWestb
Copy link
Contributor

Moes TRVs have extended functions that also need being added in ZHA for getting all advanced function to working.

I dont knowing if its 100% compatible with the old Moes TRVs but i think most shall working but no garante.

Then adding the TS061 version (MoesHY368_Type1) i think its best adding the second type 2 than its normally shoeing up very fast and its shall having the string ("_TYST11_b6wax7g0", "6wax7g0"), under MoesHY368_Type2.

@koying
Copy link
Contributor Author

koying commented Jun 21, 2021 •
edited

I'm just following up on the HA forum post. I don't own the device.
But the signature matches perfectly Type1 and not Type2

This was referenced Jun 21, 2021
Merged
Merged
Adminiuga pushed a commit that referenced this pull request Jun 21, 2021
@MattWestb
Adding nre tuya / Moes TRV (#932)
b0049a9 
Adding the second type of the _TYST11 tuy /Moes TRV.
PR is made for adding them in ZHA for getting the extended functions Moes TRV is having.

Not  tested by my or some user but #931 is some gave testing the first version but im not 110% that all is working but i think its better then no quirk for the device.
Adminiuga pushed a commit to home-assistant/core that referenced this pull request Jun 21, 2021
@MattWestb
Update climate.py (#52065)
077131d 
Adding tuya TRVs type Moes that need extra function in ZHA.
#49378 adding _TYST11/_TZE200_cwnjrr72 that is missed then being added in zigpy.
zigpy/zha-device-handlers#931 is adding the _TZE200_b6wax7g0 and i shall adding the missed _TYST11_b6wax7g0
@codecov-commenter
Copy link

Codecov Report

Merging #931 (20a8ed3) into dev (b6cbdf1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #931   +/-   ##
=======================================
  Coverage   82.54%   82.54%           
=======================================
  Files         186      186           
  Lines        4601     4601           
=======================================
  Hits         3798     3798           
  Misses        803      803
Impacted Files Coverage Δ
zhaquirks/tuya/valve.py 95.52% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6cbdf1...20a8ed3. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 957843810

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.547%
Totals Coverage Status
Change from base Build 952628130: 0.0%
Covered Lines: 3798
Relevant Lines: 4601
💛 - Coveralls

@Adminiuga Adminiuga merged commit 7820150 into zigpy:dev Jun 22, 2021
@MattWestb
Copy link
Contributor

I have adding the new Moes in ZHA so it shall getting the advance function in HA GUI but i dont knowing if its 100% compatible with the old Moes TRVs.
If not some code worrier need taking one lock to fixing it but its better then not having the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@koying @MattWestb @codecov-commenter @coveralls @Adminiuga